Conduct Code Reviews edit #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntache-81
commented
Feb 11, 2025
| All reviewers need to understand the broader context of the changes being made, including user requirements and architecture. | ||
| Lacking this context can result in misguided feedback or approval of suboptimal solutions. | ||
| All code reviewers need to understand the broader context of the changes being made, including user requirements and architecture. | ||
| Without this context, misguided feedback or approval of suboptimal solutions may occur. The best way for reviewers to gain context for code changes is to work closely with the code author during pair programming sessions. |
Collaborator
Author
There was a problem hiding this comment.
Edit OK? I feel like we stopped short of providing the reader with an action item here.
ntache-81
commented
Feb 11, 2025
|
|
||
| Code reviews can become a bottleneck if not managed effectively. | ||
| If code reviews are going to be done asynchronously, teams should establish clear guidelines for review turnaround times and distribute review responsibilities accordingly. | ||
| If code reviews are going to be done asynchronously, teams need to establish clear guidelines for review turnaround times and distribute individual review responsibilities. |
Collaborator
Author
There was a problem hiding this comment.
Is this often the case, that they’re done asynchronously? Or is this a choice? Is synchronous code reviews more efficient? Suggest clarifying.
Member
|
Going to rework this content to be a practice called: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit to Conduct Code Reviews practice