added signal declaration #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crap just saw I had a copy paste error when checking for signal in parseType. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've fixed all the issues mentioned in the prior PR #76. I fixed the
when compiles(godotTypeInfoissue and removed the call to ord. Also moved the check for thesignalcommand outside of parseSignal in case we want to add additional commands for other things in the future then we can switch on the value ofstatementinparseType. So that's why I pushed a new PR.Saving the references for the parameters for GodotSignalArgument and deinitializing them afterwards seems a little messy. If you have suggestions there, I can change it. Maybe switching to a macro and using
quote do:might be nicer? But I was trying to match the rest of the code's style.