CBMC: polyvec_[to|from]bytes(), [un]pack_pk(), polyvec_reduce()
#341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
force-pushed
the
cbmc_polyvec_tofrombytes
branch
2 times, most recently
from
c724cb2 to
cfabc5a
Compare
hanno-becker
changed the title
polyvec_tobytes() and polyvec_frombytes()polyvec_[to|from]bytes(), [un]pack_pk(), polyvec_reduce()
hanno-becker
force-pushed
the
cbmc_polyvec_tofrombytes
branch
from
cfabc5a to
dc5b7af
Compare
mkannwischer
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Thanks @hanno-becker. Looks mostly good.
Could you add the input + output bounds into the doc string like we have in the other functions?
hanno-becker
force-pushed
the
cbmc_polyvec_tofrombytes
branch
from
dc5b7af to
da58385
Compare
Resolves #337 Resolves #338 Signed-off-by: Hanno Becker <[email protected]>
Resolves #334 Resolves #331 Resolves #333 Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
cbmc_polyvec_tofrombytes
branch
from
da58385 to
738454a
Compare
mkannwischer
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #340
Fixes #337, #338, #334 #331 #333