Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude restricted users from daily challenge-related queries #243

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Sep 17, 2024

This is a port of ppy/osu-web#11488 for spectator server.

Probably worth examining from a query performance angle. I haven't really even attempted to do so because I don't have a representative database to get realistic query plans from.

@bdach bdach requested a review from peppy September 17, 2024 08:15
Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, no need for profiling.

@peppy peppy merged commit b316d32 into ppy:master Sep 17, 2024
2 checks passed
@bdach bdach deleted the restricted-user-checks branch September 18, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants