Fix EndPlaySession() not broadcasting play end to other users on unranked beatmap plays
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this is going to get annoying otherwise in a sec.
…ranked beatmap plays As discussed in ppy#224 (comment). In full-stack testing, this manifests as an actual bug wherein when spectating a player who's playing an unranked beatmap, spectator player will not exit even when the spectated player is done playing and will hang there forevermore.
peppy
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #224 (comment).
In full-stack testing, this manifests as an actual bug wherein when spectating a player who's playing an unranked beatmap, spectator player will not exit even when the spectated player is done playing and will hang there forevermore.