-
Notifications
You must be signed in to change notification settings - Fork 18
Health Check Improvements #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stevensJourney
wants to merge
18
commits into
main
Choose a base branch
from
probes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2aec7ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
commented
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PowerSync service uses a probing system to communicate health check statuses. Internally, the probe state is updated when the service becomes ready or active. This state is maintained in memory and can be exposed externally via the filesystem or HTTP endpoints.
Previously, probe state was always exposed via the filesystem by writing timestamps to
.probes/startup
,.probes/ready
, and.probes/poll
. This required the service to run with write access to the filesystem, which isn't always feasible or recommended. There was no way to disable filesystem probes.In addition, the same probe state was exposed via HTTP routes, but only if the RouterEngine started an HTTP server. This occurred only in
API
andUNIFIED
modes. InSYNC
mode, the only way to access probe state externally was through the filesystem.What's new
This PR introduces configurable probe types through the PowerSync configuration file. You can now enable or disable probe outputs via YAML:
The specified probe_types determine how probe state is exposed. Selecting http will now start an HTTP server even when running in SYNC mode.
Backwards compatibility
If no
healthchecks
configuration is provided, the service retains its previous behavior.Implementation
Internally this moves some configuration from the
service
runner to a new shared module. This should remove some minor duplication throughout our hosted codebases.