Skip to content

Update normalizeMongoConfig function and its tests to allow replica URI #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

whygee-dev
Copy link

No description provided.

Copy link

changeset-bot bot commented Apr 27, 2025

⚠️ No Changeset found

Latest commit: 59697db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@rkistner rkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and the comprehensive tests!

For this repo we do require a signed CLA for any pull requests to be able to merge it - are you able to do that?

const lookupOptions: LookupOptions = {
reject_ip_ranges: options.reject_ip_ranges ?? []
};
const lookup = makeHostnameLookupFunction(uri.host ?? '', lookupOptions);
const lookup = makeHostnameLookupFunction(uri.hosts[0] ?? '', lookupOptions);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be extended to validate all hosts instead of just the first one, but we can handle that after this PR is merged.

@@ -31,6 +31,7 @@
"@powersync/lib-services-framework": "workspace:*",
"bson": "^6.10.3",
"mongodb": "^6.14.1",
"mongodb-connection-string-url": "^3.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove uri-js below now - this was the only place it was used in this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants