-
Notifications
You must be signed in to change notification settings - Fork 18
Update normalizeMongoConfig function and its tests to allow replica URI #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes and the comprehensive tests!
For this repo we do require a signed CLA for any pull requests to be able to merge it - are you able to do that?
const lookupOptions: LookupOptions = { | ||
reject_ip_ranges: options.reject_ip_ranges ?? [] | ||
}; | ||
const lookup = makeHostnameLookupFunction(uri.host ?? '', lookupOptions); | ||
const lookup = makeHostnameLookupFunction(uri.hosts[0] ?? '', lookupOptions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be extended to validate all hosts instead of just the first one, but we can handle that after this PR is merged.
@@ -31,6 +31,7 @@ | |||
"@powersync/lib-services-framework": "workspace:*", | |||
"bson": "^6.10.3", | |||
"mongodb": "^6.14.1", | |||
"mongodb-connection-string-url": "^3.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove uri-js below now - this was the only place it was used in this package.
No description provided.