Metrics refactor #221
Merged
Metrics refactor #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of those interfaces for Opentelemetry Added a MetricsEngine that handles creation and registration of metrics
…lication, storage and API metrics Added the MetricsEngine to the service context
…ld singleton metrics instance
Added a MetricsHelper to aid with test setup for metrics
# Conflicts: # modules/module-mongodb/src/replication/ChangeStream.ts # modules/module-mongodb/test/src/change_stream_utils.ts # modules/module-postgres/test/src/slow_tests.test.ts # packages/service-core-tests/src/tests/register-sync-tests.ts
🦋 Changeset detectedLatest commit: 7c358b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rentacookie
commented
Mar 4, 2025
# Conflicts: # modules/module-mongodb/test/src/change_stream_utils.ts # modules/module-mysql/test/src/BinlogStreamUtils.ts # modules/module-postgres/test/src/wal_stream_utils.ts # packages/service-core-tests/src/tests/register-sync-tests.ts # packages/service-core/src/routes/endpoints/socket-route.ts # packages/service-core/src/routes/endpoints/sync-stream.ts # packages/service-core/src/system/ServiceContext.ts
Rentacookie
commented
Mar 11, 2025
# Conflicts: # modules/module-postgres/src/replication/WalStream.ts
# Conflicts: # packages/service-core-tests/src/tests/register-sync-tests.ts
Consolidated some extra logging info from powersync cloud runners into service runners
|
I tested this on the hosted powersync on staging, and did not pick up any issues. Metrics are still being correctly reported to Prometheus. |
… it is started in a replication context.
dylanvorster
previously approved these changes
Apr 4, 2025
stevensJourney
previously approved these changes
Apr 8, 2025
…ed powersync config
Rentacookie
dismissed stale reviews from stevensJourney and dylanvorster
via
7c358b8
dylanvorster
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored metrics to use a MetricsEngine which forms part of the service context.
Metrics and their creation are abstracted away behind interfaces decoupled from Opentelemetry.
Metrics can be created and accessed via the MetricsEngine.
Moved the metrics initialisation code out of the service and into service core. That way the initialisation code can be re-used by the powersync cloud edition.