Fix checkpoints during uploads not being applied #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Kotlin port of powersync-ja/powersync-js#558, see that PR for a more complete description.
I also had to fix some other quirks in the sync implementation here, notably:
triggerCrudUpload()
call when receiving keep-alive messages used to block the entire sync stream from receiving subsequent lines until the upload was completed. This changes that to spawn an async job that is not awaited (the trigger listening onps_crud
will still await this though).