-
Notifications
You must be signed in to change notification settings - Fork 44
feat: Add Proxy support for @powersync/node
#573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chriztiaan
wants to merge
10
commits into
main
Choose a base branch
from
proxy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b2c0dcd The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
reviewed
Apr 22, 2025
rkistner
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node package
Introduced support for specifying proxy environment variables for the connection methods. HTTP will use
EnvHttpProxyAgent
(see https://github.com/nodejs/undici/pull/2994/files#diff-e75b15c5fd859828aa0413c608603d1152bd54320aabd8ec8f73b023c924d0db) fromundici
and Websockets will useproxy-agent
. In both cases the libraries automatically use the correct env variable. For HTTP this will typically beHTTP_PROXY
orHTTPS_PROXY
and for Websockets it will beWS_PROXY
orWSS_PROXY
, with other known options also available.The HTTP dispatcher can be overridden with the
dispatcher
connect()
option:Common package
To support specifying a custom option for the connect method of the Node package, I needed to ensure that config is passed along correctly.
Testing
Easiest way to test is to create a a session access token with another demo and use it in the node demo's connector.
MITM with custom CA
Running:
Terminal 1
Terminal 2