-
Notifications
You must be signed in to change notification settings - Fork 44
chore: Expo 52 for RN demos, fixes for react-native-web demo #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ff54de4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested the demos, but the changes LGTM
This covers updating of the RN/RNW demos to use Expo 52 and changing minor config in the React-Native-Web demo to disable the SSR/server side aspects recently introduced. Updated
react
dev dependency in few packages to make tests work with a newer version resolved by the demos.For React-Native-Web you need to ensure the web output is
single
(SPA mode).I tested all the React Native demos across both Android and iOS.
Tested RNW across Android, iOS, and web.
Addresses issues mentioned in #507.