Skip to content

chore: Expo 52 for RN demos, fixes for react-native-web demo #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 8, 2025

Conversation

Chriztiaan
Copy link
Contributor

@Chriztiaan Chriztiaan commented Apr 4, 2025

This covers updating of the RN/RNW demos to use Expo 52 and changing minor config in the React-Native-Web demo to disable the SSR/server side aspects recently introduced. Updated react dev dependency in few packages to make tests work with a newer version resolved by the demos.

For React-Native-Web you need to ensure the web output is single (SPA mode).

 web: {
    bundler: 'metro',
    output: 'single',

I tested all the React Native demos across both Android and iOS.

  • We still include the Android build files.
  • The Django demo still maintains an iOS directory, I am not sure whether we still need it. Opted to just include the changes for now.

Tested RNW across Android, iOS, and web.

Addresses issues mentioned in #507.

Copy link

changeset-bot bot commented Apr 4, 2025

🦋 Changeset detected

Latest commit: ff54de4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@powersync/web Patch
@powersync/diagnostics-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Chriztiaan Chriztiaan marked this pull request as ready for review April 7, 2025 07:44
stevensJourney
stevensJourney previously approved these changes Apr 8, 2025
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the demos, but the changes LGTM

@Chriztiaan Chriztiaan merged commit 7fe70bd into main Apr 8, 2025
6 checks passed
@Chriztiaan Chriztiaan deleted the chore/rnw-expo-52-housekeeping branch April 8, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants