Skip to content

feat: Expose upload/download errors, credential management, last synced value from core extension #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Chriztiaan
Copy link
Collaborator

@Chriztiaan Chriztiaan commented May 19, 2025

Working towards API parity with newly added features from other SDKs:

  1. Updated core extension to latest release
  2. Exposing upload/download errors in SyncStatus (See feat: Exposing upload and download errors in SyncStatus powersync-js#550)
  3. Invalidating credentials when apt, instead of continuously calling fetchCredentials (see feat: Fetch credentials on token expiry/401 powersync-js#604)
  4. Loading last synced time from core extension

Edit: I am planning on moving the credential caching to the connector in a future PR.

@Chriztiaan Chriztiaan marked this pull request as ready for review May 19, 2025 13:40
@stevensJourney stevensJourney requested a review from Copilot May 19, 2025 14:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the core extension integration by updating the core release URL, exposing upload/download errors in the synchronization status, revising credential management, and loading the last synced time along with improved test coverage.

  • Updated core extension download URL in Setup.cs.
  • Expanded SyncStatus to include upload/download error details.
  • Improved credentials management and error handling in Remote.cs and StreamingSyncImplementation.cs.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Tools/Setup/Setup.cs Updated the core extension URL to v0.3.14.
Tests/PowerSync/PowerSync.Common.Tests/Client/PowerSyncDatabaseTests.cs Renamed test class and added new query and error handling tests.
PowerSync/PowerSync.Common/DB/Crud/SyncStatus.cs Exposed new properties for upload/download errors and updated logging message.
PowerSync/PowerSync.Common/Client/Sync/Stream/StreamingSyncImplementation.cs Updated error handling and credential invalidation logic.
PowerSync/PowerSync.Common/Client/Sync/Stream/Remote.cs Revised credentials fetching, removed safety period check, and added unauthorized response handling.
PowerSync/PowerSync.Common/Client/PowerSyncDatabase.cs Updated last synced time retrieval to use a sync priority.
PowerSync/PowerSync.Common/CHANGELOG.md Documented all new changes for upcoming release.

@powersync-ja powersync-ja deleted a comment from Copilot AI May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants