Type inferring for Linked Forms and Linking of DeathItems #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When LinkedForm is used SPID will pick up correct distributable type based on actual Form's type.
e.g. users can now simply write "Form = ..." instead of "Spell = ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22
This change expands Linked Forms feature by allowing to make any regular entry as linked using
Linkedprefix, e.g.LinkedItem,LinkedOutfit, etc. This also introduces type inference by allowing to writeLinkedFormand let SPID figure out form's type.As a side benefit it adds support for linking DeathItems. Note that Only DeathItems can be linked to other DeathItems 🙂
TODO:
This now also allows to write
Form = 0x12345|...without specifying type of the form you want.
Explicit form type is still useful as it can check whether user's intention matches the actual form type.
P.S. Performance impact of type inference is negligible. (2030 forms scored average ~204ms with both explicit and inferred types)