Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-924] Table kit: Custom headers - React Only #4413

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

ElisaShapiro
Copy link
Contributor

@ElisaShapiro ElisaShapiro commented Mar 20, 2025

What does this PR do? A clear and concise description with your runway ticket url.
PBNTR-924 adds the headerStyle prop to the React Table kit which allows for header customization. Two doc examples showcasing different custom headers - a borderless table on a generic background and a floating table where the header's backgroundColor can be altered to match the container in which the table is nested have been added in accordance with the investigation/POC in PBNTR-786, as have tests.

Screenshots: Screenshots to visualize your addition/change
both doc examples

How to test? Steps to confirm the desired behavior:

  1. Go to the two header style doc examples in the review environment (borderless and floating) and see how the Table without a border appears in both scenarios.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@ElisaShapiro ElisaShapiro added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Mar 20, 2025
@ElisaShapiro ElisaShapiro self-assigned this Mar 20, 2025
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-924-react-table-custom-headers

@ElisaShapiro ElisaShapiro marked this pull request as ready for review March 20, 2025 20:30
@ElisaShapiro ElisaShapiro requested a review from a team as a code owner March 20, 2025 20:30
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Mar 21, 2025
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.16.0.pre.alpha.PBNTR924reacttablecustomheaders6846

Your Alpha for NPM is 14.16.0-alpha.PBNTR924reacttablecustomheaders6846

@ElisaShapiro ElisaShapiro merged commit 254837e into master Mar 25, 2025
17 checks passed
@ElisaShapiro ElisaShapiro deleted the PBNTR-924-react-table-custom-headers branch March 25, 2025 19:16
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.17.0.pre.rc.0
- NPM: 14.17.0-rc.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants