[PBNTR-861] Advanced Table: Selectable Rows for Rails #4408
+634
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElisaShapiro
added
enhancement
…ys into checkbox functionality
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-861-adv-table-rails-selectable-rows |
ElisaShapiro
added
the
milano
nidaqg
previously approved these changes
Mar 21, 2025
nidaqg
added
Ready for Release
nidaqg
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PBNTR-861 is the first PR to get the Selectable Rows functionality to the Rails version of the Advanced Table via custom implementation.
This PR sets up new sets of json data as available for rails doc examples, enables adding a checkbox column to expandable and no subrow advanced tables with the appropriate styling (also contains a small dark mode fix present in prod for the React no subrow examples as well). They will be hidden from production after review until the follow up stories are completed. Full dynamic checkbox functionality for these two doc examples (with the expected cascading for expandable tables) and action bar functionality (added to these two doc ex and to the two additional examples React has) will come in follow up stories.
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.- [ ] TESTS I have added test coverage to my code.