Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBIOS-705] Add typeahead deselected listener #522

Merged
merged 5 commits into from
Apr 3, 2025
Merged

Conversation

isismsilva
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
Add a listener to the typeahead for when an item is deselected from the selected items.

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist

  • LABELS - Add a label: breaking, bug, improvement, documentation, or enhancement. See Labels for descriptions.
  • RELEASES - Add the appropriate label: Ready for Testing / Ready for Release
  • TESTING - Have you tested your story?

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@isismsilva isismsilva added the Ready for Testing For anything that needs testing label Mar 20, 2025
@isismsilva isismsilva self-assigned this Mar 20, 2025
@isismsilva isismsilva requested a review from a team as a code owner March 20, 2025 00:51

Verified

This commit was signed with the committer’s verified signature.
isismsilva and others added 3 commits March 27, 2025 13:57

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
**What does this PR do?** A clear and concise description with your
runway ticket url.
Added a custom textfield to the iOS target to manage digital keyboard
commands.
Now the user can delete selected items using the keyboard on iOS

**Screenshots:** Screenshots to visualize your addition/change

https://github.com/user-attachments/assets/e44b0a8f-5c3b-4c96-8e5a-69f1bb21e7ba


**How to test?** Steps to confirm the desired behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See addition/change

### Checklist
- [ ] **LABELS** - Add a label: `breaking`, `bug`, `improvement`,
`documentation`, or `enhancement`. See
[Labels](https://github.com/powerhome/playbook-apple/labels) for
descriptions.
- [ ] **RELEASES** - Add the appropriate label: `Ready for Testing` /
`Ready for Release`
- [ ] **TESTING** - Have you tested your story?

Verified

This commit was signed with the committer’s verified signature.
@isismsilva isismsilva merged commit 1076c28 into main Apr 3, 2025
2 checks passed
@isismsilva isismsilva deleted the typeahead-listener branch April 3, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Testing For anything that needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants