Skip to content

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Sep 19, 2025

The (perf) filters are there, so we only need to add it.

Summary by CodeRabbit

  • New Features

    • Added a dedicated Rolldown integration entry point, available via a new import path.
    • Supports both ESM and CommonJS consumers.
    • No changes to existing exports; fully backward compatible.
  • Chores

    • Updated build configuration to include the new entry point.

Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedmuggle-string@​0.4.11001009277100
Addedminimist@​1.2.810010010081100
Addedpicomatch@​4.0.310010010083100
Addedsemver@​7.7.210010010086100
Addedprettier@​3.6.29910010090100
Addedtypescript@​5.9.210010090100100

View full report

Copy link

pkg-pr-new bot commented Sep 19, 2025

Open in StackBlitz

npm i https://pkg.pr.new/unplugin-vue-router@725

commit: ecc50d7

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.15%. Comparing base (9cb2f52) to head (9b33238).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/rolldown.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   64.18%   64.15%   -0.04%     
==========================================
  Files          38       39       +1     
  Lines        4219     4221       +2     
  Branches      806      807       +1     
==========================================
  Hits         2708     2708              
- Misses       1504     1505       +1     
- Partials        7        8       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@posva
Copy link
Owner

posva commented Sep 25, 2025

Nice! Once I merge #700 I should be able to fix the conflicts and merge

@posva posva moved this from 🆕 New to 👀 In review in unplugin-vue-router Sep 25, 2025
Copy link
Contributor

coderabbitai bot commented Sep 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new Rolldown plugin entry point. Exposes it via package.json exports, introduces src/rolldown.ts that re-exports the Rolldown plugin from the existing unplugin, and updates tsdown.config.ts to build the new entry.

Changes

Cohort / File(s) Summary
Public exports
package.json
Adds ./rolldown export mapping to ./dist/rolldown.js (import) and ./dist/rolldown.cjs (require).
New source entry
src/rolldown.ts
New file that imports the package default and re-exports unplugin.rolldown as the default export.
Build configuration
tsdown.config.ts
Adds ./src/rolldown.ts to the entry array for bundling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cb2f52 and 9b33238.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • package.json (3 hunks)
  • src/rolldown.ts (1 hunks)
  • tsdown.config.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@posva posva merged commit 1686681 into posva:main Sep 26, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in unplugin-vue-router Sep 26, 2025
@userquin userquin deleted the add-rolldown branch September 26, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants