Skip to content

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Sep 19, 2025

When running the build script from root, I get a pnpm error; removing the single quotes from the regexp seems to fix the script's problem:

error running build script
error running build script

Summary by CodeRabbit

  • Chores
    • Standardized quoting in the build script configuration to ensure consistent regex handling across shells and CI.
    • Script filtering behavior unchanged; only quoting adjusted.
    • Improves reliability of build-related commands and reduces risk of shell-escaping issues in developer workflows and CI runs.

Copy link

pkg-pr-new bot commented Sep 19, 2025

Open in StackBlitz

npm i https://pkg.pr.new/unplugin-vue-router@721

commit: 400d3b2

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.90%. Comparing base (7a95e6a) to head (400d3b2).
⚠️ Report is 82 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   60.90%   60.90%           
=======================================
  Files          36       36           
  Lines        3379     3379           
  Branches      618      618           
=======================================
  Hits         2058     2058           
  Misses       1314     1314           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Walkthrough

Changed the build script filter in package.json's pnpm --stream invocation by replacing the single-quoted regex '/^build:/' with a double-quoted string "/^build:/", preserving the pattern and behavior.

Changes

Cohort / File(s) Summary of Changes
Build script invocation
package.json
Replaced single-quoted regex filter '/^build:/' with double-quoted "/^build:/" in the pnpm --stream build script; no behavioral changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely describes the PR’s primary change of fixing the Windows build by adjusting the build script’s regex quoting. It follows the conventional commit style and gives enough context for readers scanning the commit history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3428971 and 400d3b2.

📒 Files selected for processing (1)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Owner

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the version I changed it to works on windows?

@userquin
Copy link
Contributor Author

checking...

@userquin
Copy link
Contributor Author

Does the version I changed it to works on windows?

Yes, it works

@github-project-automation github-project-automation bot moved this from 🆕 New to 👀 In review in unplugin-vue-router Sep 25, 2025
@posva posva merged commit 9cb2f52 into posva:main Sep 26, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in unplugin-vue-router Sep 26, 2025
@userquin userquin deleted the chore-fix-buld-on-windows branch September 26, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants