Skip to content

tests: Multiple available Digest Auth strategies + Opting-in to a strategy #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

tests: Multiple available Digest Auth strategies + Opting-in to a strategy #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions test/fixtures/servers/_servers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,8 @@ function createDigestServer (options) {
expectedUsername = options.username || 'username',
expectedPassword = options.password || 'password';

passport.use(new DigestStrategy({ qop: 'auth' },
// Register Digest strategies for MD5 and SHA-256
passport.use('digest-md5', new DigestStrategy({ qop: 'auth', algorithm: 'MD5' },
function (username, done) {
if (username !== expectedUsername) {
return done(null, false);
Expand All @@ -678,8 +679,30 @@ function createDigestServer (options) {
return done(null, username, expectedPassword);
}));

passport.use('digest-sha256', new DigestStrategy({ qop: 'auth', algorithm: 'SHA-256' },
function (username, done) {
if (username !== expectedUsername) {
return done(null, false);
}

return done(null, username, expectedPassword);
}));

app.use((req, res, next) => {
if (!req.headers.authorization) {
res.status(401);
res.set('WWW-Authenticate',
'Digest realm="Users", qop="auth", algorithm="MD5", nonce="md5nonce"');
res.append('WWW-Authenticate',
'Digest realm="Users", qop="auth", algorithm="SHA-256", nonce="sha256nonce"');

return res.send('Unauthorized');
}
next();
});

app.all('*',
passport.authenticate('digest', { session: false }),
passport.authenticate(['digest-md5', 'digest-sha256'], { session: false }),
function (req, res) {
res.send(req.users);
});
Expand Down
67 changes: 67 additions & 0 deletions test/integration/auth-methods/digest.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,4 +1031,71 @@ describe('digest auth', function () {
expect(secondCall.args[2]).to.have.property('code', 200);
});
});

describe('with opted-in algorithm other than the default (md5)', function () {
before(function (done) {
var runOptions = {
collection: {
item: {
name: 'DigestAuth',
request: {
url: global.servers.digest,
auth: {
type: 'digest',
digest: {
algorithm: 'SHA-256',
Copy link
Collaborator Author

@deve-sh deve-sh Sep 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification: We're opting-in to the available strategies from the get-go

username: '{{uname}}',
password: '{{pass}}'
}
}
}
}
},
environment: {
values: [{
key: 'uname',
value: USERNAME
}, {
key: 'pass',
value: PASSWORD
}]
}
};

// perform the collection run
this.run(runOptions, function (err, results) {
testrun = results;
done(err);
});
});

it('should have completed the run', function () {
expect(testrun).to.be.ok;
expect(testrun).to.nested.include({
'done.callCount': 1
});
testrun.done.getCall(0).args[0] && console.error(testrun.done.getCall(0).args[0].stack);
expect(testrun.done.getCall(0).args[0]).to.be.null;
expect(testrun).to.nested.include({
'start.callCount': 1
});
});

it('should have tried twice and succeeded the second time', function () {
expect(testrun).to.nested.include({
'io.callCount': 2,
'request.callCount': 2
});

var firstError = testrun.io.firstCall.args[0],
secondError = testrun.io.secondCall.args[0],
firstResponse = testrun.io.firstCall.args[3],
secondResponse = testrun.io.secondCall.args[3];

expect(firstError).to.be.null;
expect(secondError).to.be.null;
expect(firstResponse).to.have.property('code', 401);
expect(secondResponse).not.to.have.property('code', 401);
});
});
});
Loading