Added alwaysInheritAuthentication option to v2 #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VShingala
reviewed
Jun 1, 2023
lib/schemaUtils.js
Outdated
| @@ -2647,7 +2647,12 @@ module.exports = { | |||
| } | |||
|
|
|||
| // handling authentication here (for http type only) | |||
| authHelper = this.getAuthHelper(openapi, operation.security); | |||
| if (options.alwaysInheritAuthentication) { | |||
| authHelper = this.getAuthHelper(openapi, openapi.security); | |||
There was a problem hiding this comment.
@SahilChoudhary22 In case when this is true, should we simply be using auth as Inherit from parent rather than defining it the same as parents? i.e. Value of authHelper should be undefined same as what's done in v2?
There was a problem hiding this comment.
@VShingala Correct! Asked the same doubt from user on the parent PR. Missed it in this PR. Have fixed with the following commit - a942449
VShingala
reviewed
Jun 6, 2023
VShingala
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
alwaysInheritAuthenticationto thev1version of converter. This one adds the support forv2on top of it and aims to make the option compatible with the latest code.A big Thanks to @AndrewGuenther for raising the above mentioned PR!