Usage of external testgres.os_ops and testgres.common #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal changes. pg_probackup2 was not changed [I think, it is broken now].
src/operations is deleted. TestgresException, ExecUtilException, InvalidOperationException are gotten from testgres.operations.exceptions
It was deleted by mistake.
dmitry-lipetsk
force-pushed
the
D20250816_001--external_os_ops_v001
branch
from
b7c33b0 to
5b6f451
Compare
dmitry-lipetsk
force-pushed
the
D20250816_001--external_os_ops_v001
branch
from
91f1c4c to
e7dc9f3
Compare
--- It seems Sphinx does not support our new project structure. So we will process an installed "instance" of testgres but not its source code.
It was restored from hell when we merged with master (postgrespro#290)
dmitry-lipetsk
force-pushed
the
D20250816_001--external_os_ops_v001
branch
from
6cc9d3b to
4219763
Compare
demonolock
reviewed
Nov 12, 2025
| from testgres import get_bin_path | ||
| from testgres import get_pg_config | ||
| from testgres import get_pg_version | ||
| from src import StartNodeException |
Contributor
There was a problem hiding this comment.
Мы же пакет тестируем. В тестех надо импортировать из пакета
demonolock
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch starts using the code from external packages:
I think we will commit parts of this patch separately.
Note
Closes #285