Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PortManager #234

Merged
merged 32 commits into from
Apr 6, 2025
Merged

PortManager #234

merged 32 commits into from
Apr 6, 2025

Conversation

dmitry-lipetsk
Copy link
Collaborator

@dmitry-lipetsk dmitry-lipetsk commented Apr 4, 2025 •
edited
Loading

Main

  • Old PortManager was deleted
  • PostresNode uses new "abstract" interface PortManager to reserve/release port number.
  • PostgresNode.free_port always resets port number
  • OsOperations::is_free_port is added
    • LocalOsOperations::is_free_port uses python socket
    • RemoteOsOperations::is_free_port uses utility nc (netcat)
  • PostgresNode.start raises exception (InvalidOperationException) if node is None

Refactoring

  • PostgresNode::port is RO-property now. It throws if port is None
  • PostgresNode::host is RO-property now
  • PostgresNode::ssh_key is RO-property now
  • PostgresNode::name is RO-property now

@dmitry-lipetsk
PostgresNode refactoring [PostgresNodePortManager and RO-properties]
09dab31 
PostgresNode uses PostgresNodePortManager to reserve/release port number

New PostgresNode RO-properties are added:
 - name
 - host
 - port
 - ssh_key
@dmitry-lipetsk
[FIX] clone_with_new_name_and_base_dir did not respect port_manager
ef095d3
@dmitry-lipetsk
PostgresNodePortManager__ThisHost is defined (was: PostgresNodePortMa…
0f842fd 
…nager__Global)

It is a singleton.
@dmitry-lipetsk
PostgresNodePortManager__Generic is added
e1e609e
@dmitry-lipetsk
PostgresNodePortManager is added in public API
285e5b7
@dmitry-lipetsk
Test structures were refactored (local, local2, remote)
a974866
@dmitry-lipetsk
CI files are updated
110947d
@dmitry-lipetsk
TestTestgresCommon.test_pgbench is added
4f49dde 
- [del] TestTestgresLocal.test_pgbench
- [del] TestTestgresRemote.test_pgbench
@dmitry-lipetsk
PostgresNodePortManager is updated [error messages]
4fbf51d
@dmitry-lipetsk
PostgresNodePortManager(+company) was moved in own file - port_manage…
17c73cb 
…r.py
@dmitry-lipetsk
PortManager was deleted [amen]
b1cee19
@dmitry-lipetsk
PostgresNodePortManager was renamed with PortManager
c5ad907
@dmitry-lipetsk
TestTestgresCommon.test_unix_sockets is added
0967057
@dmitry-lipetsk
TestTestgresCommon.test_the_same_port is added
1d450b2
@dmitry-lipetsk
[TestTestgresCommon] New tests are added
4a38b35 
- test_port_rereserve_during_node_start
- test_port_conflict
@dmitry-lipetsk
RemoteOperations::is_port_free is updated
322fb23
@dmitry-lipetsk
Tests for OsOps::is_port_free are added
94da63e
@dmitry-lipetsk
TestTestgresCommon is corrected [python problems]
88f9b73
@dmitry-lipetsk
The call of RaiseError.CommandExecutionError is fixed [message, not m…
d9558ce 
…sg_arg]

- RemoteOperations::message
- RemoteOperations::path_exists
- RemoteOperations::is_port_free
@dmitry-lipetsk
[CI] ubuntu 24.04 does not have nc
0da4c21 
Let's install it (netcat-traditional) explicitly.
@dmitry-lipetsk
RemoteOperations is update [private method names]
0058508
@dmitry-lipetsk
test_is_port_free__true is updated
8f3a566 
A number of attempts is increased to 128.

The previous value (10) is not enough and test could fail.
@dmitry-lipetsk
RemoteOperations::is_port_free is updated (comments)
d8ebdb7
@dmitry-lipetsk
setup.py is updated [testgres.helpers was deleted]
30e472c
@dmitry-lipetsk
Comment in node.py is updated
c94bbb5
@dmitry-lipetsk
PostgresNode::_node was deleted [use self._os_ops.host]
04f88c7
@dmitry-lipetsk
PostgresNode::start is corrected [error message]
0a3442a
@dmitry-lipetsk
Merge branch 'master' into D20250403_001--port_manager
30124f3
@dmitry-lipetsk
[FIX] PostgresNode.__init__ must not test "os_ops.host" attribute.
13e71d8 
- [del] assert hasattr(os_ops, "host")

During this test we get another exception:

<[AttributeError("'PostgresNode' object has no attribute '_port'") raised in repr()] PostgresNode object at 0x782b67d79dc0>
@dmitry-lipetsk
PostgresNode.free_port always set a port to None
9e14f4a 
Tests are added:
 - test_try_to_get_port_after_free_manual_port
 - test_try_to_start_node_after_free_manual_port
@dmitry-lipetsk dmitry-lipetsk merged commit 14bc733 into postgrespro:master Apr 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmitry-lipetsk