feat: Allow for App server= to take input only
#920
Merged
+29
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
reviewed
Dec 19, 2023
shiny/_app.py
Outdated
Comment on lines
471
to
474
| def has_only_input( | ||
| x: Callable[[Inputs], None] | Callable[[Inputs, Outputs, Session], None] | ||
| ) -> TypeGuard[Callable[[Inputs], None]]: | ||
| return len(signature(x).parameters) == 1 |
There was a problem hiding this comment.
I understand that the TypeGuard does provide some help for the type checker here, but still, I think it's clearer if the len(...) == 1 check is inlined in the elif statements above, and then a cast is used inside the elif blocks. As it is, I find myself jumping up and down in the code to understand what it's doing.
It would be nice if Python type checking were smarter and didn't require either of these workarounds.
shiny/_app.py
Outdated
| pass | ||
|
|
||
|
|
||
| def ignore_output_session_server( |
There was a problem hiding this comment.
Suggested change
| def ignore_output_session_server( | |
| def wrap_server_fn_with_output_session( |
shiny/_app.py
Outdated
| @@ -446,3 +452,29 @@ def file_response_handler(req: Request) -> FileResponse: | |||
| file_response_handler, | |||
| name="shiny-app-static-assets-" + mount_point, | |||
| ) | |||
|
|
|||
|
|
|||
| def noop_server(input: Inputs, output: Outputs, session: Session) -> None: | |||
There was a problem hiding this comment.
For clarity:
Suggested change
| def noop_server(input: Inputs, output: Outputs, session: Session) -> None: | |
| def noop_server_fn(input: Inputs, output: Outputs, session: Session) -> None: |
gadenbuie
added a commit
that referenced
this pull request
Jan 5, 2024
schloerke
added a commit
that referenced
this pull request
Jan 8, 2024
* main: (24 commits) Use dynamic version of py-shiny for deploy tests (#970) Add underscores to hide some imports (#978) Add rsconnect json files(shinyapps.io tests) and folium tests (#928) Express' `value_box()` no longer includes named positional args (#966) Include `tooltip()` and `popover()` in express (#949) Remove extra call to run_express() Call `tagify()` early to intercept `AttributeErrors` (#941) Don't pass sidebar twice to navbar_page Update changelog Update changelog Switch from `requests` to `urllib` (#940) Bump version to 0.6.1.1 Fix docstring for page_opts Fix API doc sections for Express Smarter, lazier, and more complete page default/api for express (#893) Change `express.layout` to `express.ui` (#904) Remove `@output` from examples (#790) feat: Allow for `App` `server=` to take `input` only (#920) Add fixes for type stub generation (#828) Move quarto express docs to bottom ...
wch
pushed a commit
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #793