chore!: Add python 3.13 support by schloerke · Pull Request #1711 · posit-dev/py-shiny

schloerke · 2024-10-01T18:58:56Z

Python 3.13 has been delayed until 2024-10-07

Requires actions/python-versions#308 Python 3.13 has been delayed until 2024-10-07

* main: tests(sidebar): Add tests for sidebar (#1715) tests(accordion): Add kitchensink tests for accordion (#1710) tests(bug): Use locator instead of element handles (#1716) tests(deploys): Move import from htmltools into code to help with debugging deploys (#1718) build: set Narwhals 1.9.1 as minimum, remove upper bound, use narwhals.stable.v1 for dtypes and typing (#1717) feat: support DataFrames via narwhals (#1570) Adds Deploy to Connect Cloud buttons to app READMEs (#1709)

…into bump_versions

This reverts commit cf723ec.

…tible with py3.13

This reverts commit 5e7a61c.

This reverts commit 02e8f91.

schloerke · 2024-10-07T17:41:14Z

greenlet is having trouble compiling. Will wait until there is an official 3.13 release. Not too worried as we do not have compiled code.

schloerke · 2024-10-11T02:12:58Z

greenlet==3.0.3 is required by playwright v1.47.0. As of this comment v1.47.0 is the latest version on PyPI.

microsoft/playwright-python#2589 has been merged to main two days ago adding python 3.13 support and updating greenlet to a python 3.13 compatible version.

This dependency hell is frustrating to deal with as it is out of our control. 🔔 **shame.png

schloerke · 2024-10-11T02:29:36Z

Getting past playwright, we hit tokenizers failure to build. Related GitHub Issue: huggingface/tokenizers#1639

They're waiting for more upstream changes. ⏳

cpsievert · 2025-02-26T21:04:44Z

@schloerke this PR is pretty close to passing, but since modin can't install on 3.13, that leads to some typing issues with data_frame and table tests. Would you be interested in having a pass at resolving those?

karangattu · 2025-03-07T15:44:23Z

@schloerke this PR is pretty close to passing, but since modin can't install on 3.13, that leads to some typing issues with data_frame and table tests. Would you be interested in having a pass at resolving those?

This should be resolved now

schloerke · 2025-04-08T05:22:07Z

Once merged, update the required test to include build-docs (3.13)

Copilot

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/pytest.yaml:75

[nitpick] The step name 'Set up Python 3.10' is misleading given that the test matrix now includes Python 3.13. Consider renaming it to a generic name like 'Set up Python' or dynamically using the version under test.

        - name: "Set up Python 3.10"

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

cpsievert · 2025-07-22T18:26:47Z

@schloerke is this ok to merge?

schloerke · 2025-07-22T18:51:27Z

There's some failing tests that won't go away. I'll need to double check them. But we should work to get this merged.

This reverts commit 25eeeed.

schloerke · 2025-07-23T20:53:51Z

Remaining check is unrelated to python 3.13. Hoping this latest check will successfully pass

I believe this PR can be merged.

schloerke · 2025-07-23T20:54:38Z

The branch requirements have been changed. Any other PRs will need to be updated

schloerke · 2025-07-23T20:55:16Z

This PR should be merged to merge in the updated workflows jobs that are now required.

schloerke · 2025-07-23T20:59:48Z

Am going to force merge. We can fix the 3.13 nba app error tomorrow

For #1711

schloerke added 3 commits October 1, 2024 14:57

Drop python 3.8. Add python 3.13

d281879

Update 3.13 python versions to 3.13-dev

fdc685c

Remove WrapAsync code

21f1022

schloerke force-pushed the bump_versions branch from 136d29c to 21f1022 Compare October 1, 2024 19:13

schloerke added 2 commits October 1, 2024 15:17

Use 3.13.0-rc.2 version

958b051

Bump python version to 3.13.0-rc.3

d07d067

Requires actions/python-versions#308 Python 3.13 has been delayed until 2024-10-07

schloerke mentioned this pull request Oct 1, 2024

chore: Drop testing of python 3.8 (incomplete) #1712

Merged

schloerke added 12 commits October 1, 2024 16:47

Merge branch 'main' into bump_versions

0ecd6dc

Merge branch 'main' into bump_versions

fe6e2da

Try short version

43fd104

Merge branch 'bump_versions' of https://github.com/posit-dev/py-shiny …

97bba3f

…into bump_versions

Update pytest.yaml

8f9e8c1

Allow for pre-releases

257f7f6

try using pip for now. Revert commit later!

cf723ec

Revert "try using pip for now. Revert commit later!"

5e7a61c

This reverts commit cf723ec.

Update playwright as 1.43 depends on greenlet version that is incompa…

62d52ae

…tible with py3.13

Reapply "try using pip for now. Revert commit later!"

02e8f91

This reverts commit 5e7a61c.

Revert "Reapply "try using pip for now. Revert commit later!""

70dfdfa

This reverts commit 02e8f91.

schloerke commented Oct 10, 2024

View reviewed changes

Comment thread .github/py-shiny/setup/action.yaml Outdated

Remove allow-prereleases: true flag

a304dba

Use playwright version from github until next release

5a84f69

schloerke commented Oct 22, 2024

View reviewed changes

Comment thread pyproject.toml Outdated

Use playwright v1.48.0 w/ Py3.13 support

4b8bb6a

schloerke changed the title ~~[WIP] chore!: Drop python 3.8. Add python 3.13~~ [WIP] chore!: Add python 3.13 support Oct 22, 2024

Merge branch 'main' into bump_versions

6afc4a9

gadenbuie added this to the Next Release milestone Feb 19, 2025

cpsievert added 3 commits February 26, 2025 11:59

Don't install ray on pyton 3.13

3db13c0

Do same for modin

42ee7a2

Undo test_chat changes

40cc6da

cpsievert and others added 2 commits March 3, 2025 12:10

Merge branch 'main' into bump_versions

e450da5

fix(tests): skip modin tests if python version == 3.13 (#1882)

b8b6d24

Merge branch 'main' into bump_versions

41af702

schloerke changed the title ~~[WIP] chore!: Add python 3.13 support~~ chore!: Add python 3.13 support Apr 8, 2025

schloerke requested a review from Copilot April 8, 2025 05:21

Copilot AI reviewed Apr 8, 2025

View reviewed changes

Comment thread tests/playwright/shiny/components/table/test_table.py Outdated

schloerke and others added 2 commits April 8, 2025 01:25

Skip test w/ modin for anyting >= 3.13

a3f675b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into bump_versions

4d52c45

schloerke added 3 commits July 22, 2025 15:22

Remove the headache of modin

eae8fab

remove build-docs version matrix. Just use variable once

25eeeed

Revert "remove build-docs version matrix. Just use variable once"

bdbd318

This reverts commit 25eeeed.

schloerke enabled auto-merge (squash) July 23, 2025 20:50

Merge branch 'main' into bump_versions

cc17358

schloerke disabled auto-merge July 23, 2025 20:59

schloerke merged commit e51ffbb into main Jul 23, 2025
119 of 122 checks passed

schloerke deleted the bump_versions branch July 23, 2025 21:00

schloerke added a commit that referenced this pull request Jul 24, 2025

Update CHANGELOG.md

280d74c

For #1711

schloerke mentioned this pull request Jul 24, 2025

chore(py3.13): Update changelog and test on less jobs in draft mode #2040

Merged

Conversation

schloerke commented Oct 1, 2024 • edited by cpsievert Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

schloerke commented Oct 7, 2024

Uh oh!

Uh oh!

schloerke commented Oct 11, 2024

Uh oh!

schloerke commented Oct 11, 2024

Uh oh!

Uh oh!

cpsievert commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karangattu commented Mar 7, 2025

Uh oh!

schloerke commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cpsievert commented Jul 22, 2025

Uh oh!

schloerke commented Jul 22, 2025

Uh oh!

schloerke commented Jul 23, 2025

Uh oh!

schloerke commented Jul 23, 2025

Uh oh!

schloerke commented Jul 23, 2025

Uh oh!

schloerke commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

schloerke commented Oct 1, 2024 •

edited by cpsievert

Loading

cpsievert commented Feb 26, 2025 •

edited

Loading

schloerke commented Apr 8, 2025 •

edited

Loading