Skip to content

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Mar 23, 2024

Subset of uv installation from #1211

Require users to use .venv folder and not venv.

By using uv to install, GHA install time is reduced from ~90s to ~25s.

Q:

  • Should we auto remove the legacy venv folder? Present a message? Do nothing?
  • Should we instead make uv leverage venv folder (and not .venv by default)?

…between files that are to be built and targets; Consolidate install methods
* main:
  test(CI): Add merge queue support for faster PR testing (#1265)
  fix(panel_conditional): Include `.shiny-panel-conditional` class (#1257)
  feat: Create `Session.set_message_handler(name, handler)` (#1253)
  Fix input name
  Enable error console when running locally. (#1060)
  test: Update test to use variable, not capture stdout (#1236)
  test: Fix deploys for shinyapps.io and connect (#1224)
  chore(test): Playwright test refactors and clean up (#1204)
@schloerke
Copy link
Collaborator Author

As much as I like this PR, it requires that the user has a .venv folder. While this is automatically handled, it is too opinionated for a public usage repo (where as it would be fine for the website).

Closing as #1565 contains a good middle ground solution of using uv on CI, but not requiring users to have uv or use uv's .venv.

@schloerke schloerke closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant