Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cols_hide #86

Merged
merged 2 commits into from
Dec 14, 2023
Merged

fix: cols_hide #86

merged 2 commits into from
Dec 14, 2023

Conversation

machow
Copy link
Collaborator

@machow machow commented Dec 14, 2023 •
edited
Loading

This PR fixes cols_hide() which was raising an error when multiple columns were specified, due to set_col_hidden() not returning anything (my bad!).

Now the new method set_cols_hidden():

  • doesn't mutate anything
  • returns a new boxhead

@machow machow marked this pull request as ready for review December 14, 2023 18:46
@machow machow requested a review from rich-iannone December 14, 2023 18:46
@machow machow merged commit 036a630 into main Dec 14, 2023
6 checks passed
@rich-iannone rich-iannone deleted the fix-cols-hide branch December 14, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machow @rich-iannone