Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pre-commit checks #78

Merged
merged 3 commits into from
Dec 12, 2023
Merged

ci: pre-commit checks #78

merged 3 commits into from
Dec 12, 2023

Conversation

machow
Copy link
Collaborator

@machow machow commented Dec 11, 2023

This PR addresses #4 by running pre-commit checks in CI.

@machow machow marked this pull request as ready for review December 11, 2023 22:40
@machow
Copy link
Collaborator Author

machow commented Dec 11, 2023

@rich-iannone I fixed a few of the errors/warnings flagged by flake8, and then commented out the rest, so we can go over them when pairing! (I don't know if an exclamation is the right level of enthusiasm for flake8 errors but maybe it is?!)

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great!

@machow machow merged commit 99cdfcd into main Dec 12, 2023
6 checks passed
@rich-iannone rich-iannone deleted the ci-code-checks branch December 14, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants