Skip to content

Fix: Row striping font color contrast with background #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

juleswg23
Copy link
Collaborator

@juleswg23 juleswg23 commented Aug 1, 2025

Summary

See related issue. The color of the text of gt-striped rows does not get contrasted with the striping color.

From talking with Rich, we've revised rgba(128,128,128,0.05) to #F4F4F4 as the default striping color, since we don't need to use transparency.

Related GitHub Issues and PRs

Checklist

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.43%. Comparing base (8e35cc1) to head (472d107).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   91.44%   91.43%   -0.01%     
==========================================
  Files          47       47              
  Lines        5551     5547       -4     
==========================================
- Hits         5076     5072       -4     
  Misses        475      475              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot temporarily deployed to pr-745 August 1, 2025 15:59 Destroyed
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Row striping text coloring not contrasted with background.
2 participants