Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the related docs about mask= parameter in loc.body() #589

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

jrycw
Copy link
Collaborator

@jrycw jrycw commented Jan 27, 2025

Hello team,

This PR updates the documentation related to the mask= parameter in loc.body().

Additionally, it addresses a bug where error messages were not being rendered correctly.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (d71ee99) to head (4293de4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files          46       46           
  Lines        5416     5416           
=======================================
  Hits         4914     4914           
  Misses        502      502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrycw
Copy link
Collaborator Author

jrycw commented Jan 27, 2025

I suggest keeping the mask= experimental callout to address potential edge cases we might not have considered (related issue #588).

Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! @jrycw, we added you as a writer to this repo, so you should be able to open PRs from a clone of this repo itself (rather than a fork), and trigger doc build previews. Thanks again for all the incredible work you've done -- however we can make this easier, we're happy to figure out!

@machow machow merged commit 3290208 into posit-dev:main Jan 27, 2025
14 checks passed
@jrycw jrycw deleted the docs-style-locbody branch January 28, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants