-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: add blog post promoting the mask=
parameter in loc.body()
#584
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 90.73% 90.73%
=======================================
Files 46 46
Lines 5416 5416
=======================================
Hits 4914 4914
Misses 502 502 ☔ View full report in Codecov by Sentry. |
By the way, has anyone noticed that we've hit 2000 stars? 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yo, this article is so handy! WDYT of moving the 3rd section, where you demonstrate mask=
up to be the top one (instead of for-loop). This way, people get the most desirable nice thing up front. I think one demo of a painful alternative would be okay, but wonder if two might start to drag a bit (@rich-iannone mentioned preferring the list to loc body demo vs the for loop).
What about this?
- mask example up top
- two mask example sections, so people get to see it shine (e.g. @rich-iannone suggested a second section showing you style nulls)
- a final section showing one painful alternative (maybe the list to loc.body() approach?)
In any event, mask is a killer feature -- so really appreciate you contributing it AND this post 😁
@rich-iannone and @machow, thanks for the prompt feedback. I ended up doing the following modifications:
I hope these changes make sense to you. Please feel free to comment if something doesn't. By the way, may I ask for the privilege to trigger preview docs (not the official deployment environment) so I can immediately check whether the style looks right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yooo this is looking really nice. I noticed that the black fill for null values is quite strong. WDYT of making null value text color "grey" or "lightgrey"? That way, the effect is similar to fading out missing values, so they're less prominent.
Otherwise, the article looks really great -- thanks again for this, we'll release the new version in a sec, and are pumped to share the post!
No need to include us as authors -- you definitely did all the work here 😁
(We're looking into making previews easier for you to trigger)
We released year_cols = ["2014", "2015", "2016", "2017"] and we'll get properly-formatted years as column names. |
@machow and @rich-iannone, thank you for the feedback. I've updated the background color to |
Thanks so much for this post (and thank you for your patience with our suggestions). We'll likely merge this Monday morning and then do some announcements around this post and the |
Hello team,
I'd like to propose a blog post to promote the new
mask=
parameter inloc.body()
. Feedback is always welcome!The post is relatively short, and perhaps the team could extract some content to incorporate into the release blog for
0.16.0
.