feat: add mjml authoring support. #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds MJML authoring support to the emailer-lib package and consolidates the documentation structure. Tags are programmatically generated from the official MJML specification rather than manually maintained.
Key changes:
- Added Python MJML authoring module with auto-generated tag functions
- Restructured project by moving reference docs from root to
docs/directory - Removed legacy
emailer-lib/subdirectory in favor of top-level package structure
Reviewed Changes
Copilot reviewed 45 out of 73 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated package configuration, moved dev dependencies, added test paths for MJML tests |
| emailer_lib/mjml/_core.py | Core MJML tag classes with rendering and HTML conversion functionality |
| emailer_lib/mjml/tags.py | Auto-generated MJML tag functions (1559 lines) |
| emailer_lib/mjml/scripts/generate_tags.py | Script to programmatically generate tag functions from MJML specification |
| emailer_lib/mjml/tests/test_*.py | Test suites for MJML core functionality and tag behavior |
| examples/*.py | Updated import paths from data_polars to docs.data_polars |
| docs/_quarto.yml | Added MJML authoring section with all MJML tags to documentation |
| Makefile | Added targets for building docs, running tests, and generating MJML tags |
| .github/workflows/ci.yml | Updated CI paths to reflect new project structure |
| reference/* | Removed old reference documentation files (now generated in docs/) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the project structure, documentation, and CI workflow.
Tags are generated programmatically from the list of tags found in the mjml docs