Add derived data series in Statement of Assets Chart

[mierin12]

Hello, this is a proposition to add derived data series to the statement of assets chart.

Closes #605
Closes #707
Closes #1529
Issue : https://forum.portfolio-performance.info/t/delta-diagramm-fur-ausgewahlte-aktien/6787

Results :

This is based on the PR #3754 from @shivampaw. As it was without update since February, I am proposing some modifications taking into account the previous review.

Main updates from #3754 :

• Dedicated selection dialog for the derived data series.
  

• In the new data series selection dialog, I am proposing a different tree order :

  • [derived data]/Accounts & Portfolio/Account
    
    I find it more intuitive than
  • Accounts & Portfolio/Account/[derived data]

• Securities are added as a possible subtype of the derived data. I guess this is well applicable/defined ?

• The derived data series are correctly plotted as bar or with an area when this is relevant. This was missing.

Note on taxonomy labels :
For the selection labels, two propositions (without/with commit 8120e87) :

• with fullPath that I prefer but which is different than the existing behavior,
  
• with the same behavior as the existing data series selection
  

Multiselection topic :
There is no multiselection issue I believe.
Multiselection allows here to plot several distinct derived data series.

Legend label :
Lots of ( ) maybe another format could be used ?
Delta (for the reporting period) (Portfolio A)
Delta (for the reporting period) [Portfolio A]
?

Other forum threads

Issue: https://forum.portfolio-performance.info/t/customize-filter-invested-capital/15474
Issue: https://forum.portfolio-performance.info/t/delta-fur-klassifizierung-anzeigen/15669
Issue: https://forum.portfolio-performance.info/t/graphs-of-investment-and-performance/23365
Issue: https://forum.portfolio-performance.info/t/filtermoglichkeit-allgemeiner-datenreihen/25460
Issue: https://forum.portfolio-performance.info/t/add-invested-capital-in-one-account-to-charts/10854
Issue: https://forum.portfolio-performance.info/t/investiertes-kapital-eines-depots-anzeigen-lassen/20766
Issue: https://forum.portfolio-performance.info/t/delta-im-berechnungszeitraum-fur-einzelne-depots/17238
Issue: https://forum.portfolio-performance.info/t/investiertes-kapital-in-vermoegensaufstellung-pro-konto/13855
Issue: https://forum.portfolio-performance.info/t/zeitlicher-verlauf-des-werts-im-moment-der-investition-vs-aktueller-wert/20326
Issue: https://forum.portfolio-performance.info/t/investiertes-kapital-nach-klassifikation-im-vermogensaufstellungsdiagramm/28110
Issue: https://forum.portfolio-performance.info/t/is-it-possible-to-make-a-custom-invested-capital-remove-bank-saving-from-chart/27167

[mierin12]

Little update to avoid the selection of securities for Interest/Interest charge and their accumulated data.

I was wondering about doing the same for Taxes and Taxonomies as it should always return 0 right ? But it is also a way for the users to see it by themselves.

Thinking of it, Interest/Interest charge and their accumulated data could also be simplified by removing Securities Account ? DataSeries.Type.PORTFOLIO_PLUS_ACCOUNT included, but DataSeries.Type.PORTFOLIO not included ? To further unclutter.-> Done

[mierin12]

Hmmm I have just learned that for Security, tax are not included in the performance, and since the StatementOfAssetsSeriesBuilder is using the performance index, tax/tax accumulated for securities are 0 in the chart.
In the SecuritiesPerformanceView, total tax is shown, but I am not sure if this can easily be used a real data series.
What would be the expectation of the Statement of Assets chart on this topic ? Security's performance related taxes (0) or the real taxes? I guess it is better to be consistent with the other derived data series of security, so to keep 0, to stay consistent with the delta data series for example which is assuming tax =0.

[mierin12]

Hello @buchen, what do you think ? I understand that this one may require a longer uninterrupted time slot for the review, otherwise, just in case you simply missed it.

[mierin12]

Note : I did not manage to rebase locally to the latest master. But I managed to rebase after squashing the commits into a single one. For this single clean commit I tried to put both @shivampaw and me in co-author, I think this worked. if this is the correct way to do (?).

It will maybe be easier to work and review from this new branch:
master...mierin12:portfolio:pr-3754_rebased_derived_data_in_stat_of_assets_backup2