Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickHouse: Operator and instances #5708

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

ClickHouse: Operator and instances #5708

wants to merge 16 commits into from

Conversation

nlamirault
Copy link
Collaborator

Signed-off-by: Nicolas Lamirault [email protected]

Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault nlamirault added priority/medium This issue or PR may be useful, and needs some attention status/in_progress This issue or PR is being worked on, and has someone assigned kind/feature Categorizes issue or PR as related to a new feature area/kubernetes Kubernetes lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Sep 12, 2024
@nlamirault nlamirault self-assigned this Sep 12, 2024
@github-actions github-actions bot added cloud/homelab Cloud Provider / Homelab size/l Size L labels Sep 12, 2024
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault nlamirault changed the title Clickouse: Operator and instances ClickHouse: Operator and instances Sep 12, 2024
Signed-off-by: Nicolas Lamirault <[email protected]>
Copy link

gitguardian bot commented Sep 12, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13771724 Triggered Generic Password 52d6454 gitops/argocd/charts/database/clickhouse-operator/templates/clickhouse-test.yaml View secret
13773472 Triggered Generic Password f298915 gitops/argocd/charts/database/clickhouse-operator/templates/clickhouse-test.yaml View secret
13773472 Triggered Generic Password 52d6454 gitops/argocd/charts/database/clickhouse-operator/templates/clickhouse-test.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Kubernetes cloud/homelab Cloud Provider / Homelab kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/medium This issue or PR may be useful, and needs some attention size/l Size L status/in_progress This issue or PR is being worked on, and has someone assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant