Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: High CPU caused by rescan loop #7

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: High CPU caused by rescan loop #7

merged 1 commit into from
Jul 25, 2022

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Jul 22, 2022

@mmstick mmstick requested review from a team July 22, 2022 15:29
@mmstick mmstick force-pushed the wireplumber_jammy branch from 502733c to cb90ed3 Compare July 22, 2022 15:35
@gangwerz gangwerz self-assigned this Jul 25, 2022
gangwerz
gangwerz approved these changes Jul 25, 2022
View reviewed changes
Copy link

@gangwerz gangwerz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wireplumber-pr7.txt

Looks good! This PR passed the Pipewire testing 👍

Tested on a Pop 22.04 galp5-1650Ti and a Pop 22.04 VM

@mmstick mmstick merged commit e271407 into master_jammy Jul 25, 2022
@mmstick mmstick deleted the wireplumber_jammy branch July 25, 2022 19:06
mmstick pushed a commit that referenced this pull request Jul 17, 2024
@stefanu21 @gkiagia
log: set empty string to not set log_fields
7ee69a9 
not all functions in glib returns a value for the used log fields
in this case a 'g_return_val_if_fail(..) will only set 4 fields an
set the other field to NULL which leads to a segfault

Jul 22 13:41:37 Cynap-Pro-01121508 systemd-coredump[7247]: Process 496 (wireplumber) of user 4242 dumped core.

                                                           Stack trace of thread 496:
                                                           #0  0x00007f6b2ce58e99 __strlen_avx2 (libc.so.6 + 0x150e99)
                                                           #1  0x00007f6b2cf3ebe5 g_log_writer_journald (libglib-2.0.so.0 + 0x5fbe5)
                                                           #2  0x00007f6b2d0a9316 wp_log_fields_write_to_journal (libwireplumber-0.5.so.0 + 0x2b316)
                                                           #3  0x00007f6b2d0a96f5 wp_log_writer_default (libwireplumber-0.5.so.0 + 0x2b6f5)
                                                           #4  0x00007f6b2cf3cf3e g_log_structured_array (libglib-2.0.so.0 + 0x5df3e)
                                                           #5  0x00007f6b2cf3d0ae g_log_structured_array (libglib-2.0.so.0 + 0x5e0ae)
                                                           #6  0x00007f6b2cf3d4b7 g_logv (libglib-2.0.so.0 + 0x5e4b7)
                                                           #7  0x00007f6b2cf3d7ef g_log (libglib-2.0.so.0 + 0x5e7ef)
                                                           #8  0x00007f6b29efafef get_node_by_id (libwireplumber-module-cb-ipc.so + 0x24fef)
                                                           #9  0x00007f6b29efb032 wp_cb_ipc_get_app_properties (libwireplumber-module-cb-ipc.so + 0x25032)
@ADSA-Golden ADSA-Golden mentioned this pull request Aug 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gangwerz gangwerz gangwerz approved these changes

@13r0ck 13r0ck 13r0ck approved these changes

Assignees

@gangwerz gangwerz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipewire or Wireplumber using 100% CPU after using Bluetooth microphone
3 participants
@mmstick @gangwerz @13r0ck