Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: new logger #1562

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

wip: new logger #1562

wants to merge 2 commits into from

Conversation

typedarray
Copy link
Collaborator

@typedarray typedarray commented Feb 26, 2025

  • Replaces pino with a custom logger better tailored to our requirements
  • New logger has a narrow schema, custom error serialization, and uses a worker thread

TODOs

  • Quick benchmark
  • Test against error serialization regressions

The worker-based logger is incompatible with ink, so we only enable it when the terminal UI is disabled. This is because ink uses a console.log monkeypatch to ensure that logs appear above the auto-updating terminal UI. If you write directly to stdout (like the worker does) ink breaks. If we got rid of ink, we could use the worker logger at all times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant