Feat/factory supports parameter within struct #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typedarray
reviewed
Dec 16, 2024
| @@ -6,6 +6,21 @@ const llamaFactoryEventAbiItem = parseAbiItem( | |||
| "event LlamaInstanceCreated(address indexed deployer, string indexed name, address llamaCore, address llamaExecutor, address llamaPolicy, uint256 chainId)", | |||
| ); | |||
|
|
|||
| const FactoryEventSimpleParamsAbiItem = parseAbiItem([ | |||
There was a problem hiding this comment.
- I think you need to use
parseAbihere because there are multiple items - We use
camelCasefor most identifiers
There was a problem hiding this comment.
- In case of function/event with struct, parseAbiItem can be used https://viem.sh/docs/abi/parseAbiItem#parameters . As parseAbiItem was already in use, I preferred to stick to it.
- Refactored, camelCase all the way. 🫡
| "struct MarketParams {address loanToken; address collateralToken; address oracle; address irm; uint256 lltv;}", | ||
| ]); | ||
|
|
||
| const FactoryEventWithDynamicChildParamsAbiItem = parseAbiItem([ |
There was a problem hiding this comment.
We should also include a test case where a struct/array is one of the indexed arguments and the user attempts to use one of its properties as the child address parameter. I think we'll have to validate against this - the address is not actually available in the event body because the value gets hashed and then stored as one of the topics.
typedarray
reviewed
Dec 17, 2024
…reaking down struct to find param
Jds-23
force-pushed
the
feat/factory-supports-parameter-within-struct
branch
from
d264faf to
211b0f6
Compare
…the user attempts to use one of its properties as the child address parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Not Complete Yet]
@typedarray