Skip to content

Implementation Aggregator Demo #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

dOrgJelli
Copy link
Contributor

Create a simple implementation aggregator demo. Things left to do:

  • create CI/CD pipeline, allowing anyone to PR in new implementation wrappers and add them to the root wrapper
  • create app that uses the live aggregation wrapper

@Niraj-Kamdar Niraj-Kamdar changed the base branch from main to dev September 5, 2022 08:57
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the example, we only need a better aggregator :)

pub mod wrap;
pub use wrap::*;

pub fn get_animals(args: ArgsGetAnimals) -> Vec<String> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive the aggregator example should be better than this. It should actually call one or more of implementations depending on conditions.

I have an idea will do some changes in this

@dOrgJelli dOrgJelli marked this pull request as ready for review September 27, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants