fix(intentsV2): decode hex state machine IDs in estimateFillOrderV2#286
Open
ddboy19912 wants to merge 2 commits intomainfrom
Open
fix(intentsV2): decode hex state machine IDs in estimateFillOrderV2#286ddboy19912 wants to merge 2 commits intomainfrom
ddboy19912 wants to merge 2 commits intomainfrom
Conversation
Contributor
|
Please point these changes to my branch if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The estimateFillOrder is incosistent with other methods. Other methods expect the order source and destination in hex format. This causes the estimation to break
We could also improve the interface so it's certain what these methods expect. It would also help clear the assertions