Rename the 'context' option in Java to be 'contexts'. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Road to R24
aarongoin
reviewed
Sep 5, 2025
...ven-plugin/src/main/java/io/polyapi/plugin/service/generation/PolyGenerationServiceImpl.java
Outdated
Show resolved
Hide resolved
aarongoin
approved these changes
Sep 16, 2025
Member
aarongoin
left a comment
aarongoin
left a comment
There was a problem hiding this comment.
Nice! Thanks Sasa!
Let's make sure we merge any changes into develop though. I've changed the base to be develop in your PR. Please look things over and make any adjustments if needed before merging.
Author
|
Hi Aaron, it sims as can not be merged yet because there are some uncompleted checks : Maven Clean VerifyExpected — Waiting for status to be reported |
Member
|
@sasajo Okay I guess I had to manually approve the Maven Clean Verify workflow in order for it to run. That's odd. I'll look at why we need that--ideally it should just run. Anyway, you should be clear to merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.