Add logo.dev for business emails
#8292
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
pieterbeulque
force-pushed
the
pieter/add-logo-dev
branch
from
7ee6ba7 to
b63bd24
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
3 similar comments
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
@frankie567 Care to take a look at the Python part? 🙇 |
| _name_description = "The name of the customer." | ||
| _name_example = "John Doe" | ||
|
|
||
| _personal_email_domains: set[str] = { |
There was a problem hiding this comment.
Could we put that under config.py in Settings? Would allow us to easily override it dynamically if needed.
server/polar/organization/service.py
Outdated
|
|
||
| # Ignore logo.dev URLs for avatar_url - these are computed values | ||
| # that the frontend may inadvertently send back | ||
| if avatar_url := update_dict.get("avatar_url"): |
There was a problem hiding this comment.
That logic should be made as a validator and applied at schema level.
def _discard_logo_dev_url(url: HttpUrl) -> HttpUrl | None:
if url.host and url.host.endswith("logo.dev")
return None
return url
AvatarUrl = Annotated[HttpUrlToStr, AfterValidator(_discard_logo_dev_url)]
class OrganizationCreate(Schema): # and OrganizationUpdate
avatar_url: AvatarUrl | None = None
pieterbeulque
force-pushed
the
pieter/add-logo-dev
branch
from
dff870e to
a086ae3
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 similar comment
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
pieterbeulque
force-pushed
the
pieter/add-logo-dev
branch
from
f66c7aa to
974e4ed
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 similar comment
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
pieterbeulque
force-pushed
the
pieter/add-logo-dev
branch
from
974e4ed to
3409950
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
pieterbeulque
force-pushed
the
pieter/add-logo-dev
branch
from
3409950 to
4349ee3
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Good call on the validator, @frankie567, that's a lot cleaner. Can you take another look? |
We'd need to purchase a license to do it in prod, but it looks way nicer for B2B.