pqarrow/arrowutils: Add sorting support for Struct, RunEndEncoded, FixedSizeBinary #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalmatze
force-pushed
the
arrowutils-sort-dict-fixedbinary
branch
4 times, most recently
from
4751bc3 to
6e043a8
Compare
|
Hey @thorfour, any idea why |
Replace the assert with |
|
Done: |
metalmatze
force-pushed
the
arrowutils-sort-dict-fixedbinary
branch
from
dd0ae83 to
1ff59c3
Compare
This will also allow us to limit all the newly supported column types, timestamp, struct and runendencoded
Please take a look at this fix, @thorfour. I'm not sure why this started panicking now.
metalmatze
commented
Nov 26, 2024
Comment on lines
+177
to
+180
| // The size can be 0 and in that case we don't want to sample. | ||
| if s.size == 0 { | ||
| return | ||
| } |
There was a problem hiding this comment.
@thorfour, this sometimes panics all of a sudden.
Specifically line 189/193 with the rand.Intn(int(s.size).
I'm not sure why we're sometimes running into this now. But this guard at least stops the panic.
thorfour
approved these changes
Nov 26, 2024
brancz
approved these changes
Nov 26, 2024
pqarrow/arrowutils/sort_test.go
Outdated
| t.Run("List", func(t *testing.T) { | ||
| mem := memory.NewGoAllocator() | ||
| // mem := memory.NewCheckedAllocator(memory.NewGoAllocator()) |
There was a problem hiding this comment.
True. I tried to fix it and gave up. Let me take another look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RunEndEncoded part made my brain melt a couple of times. The Struct part is weird cause it always assumes the fields of a struct a multiple when creating the new struct array with
array.NewStructArray(cols, names), so I had to figure that out and adjust the schema. FixedSizeBinary is simple compared to the other two.