db: perform a snapshot if WAL contains persisted entries #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the uncompressed insert size would not be initialized correctly after recovery, this could cause L0 size to grow
thorfour
approved these changes
Oct 23, 2023
asubiotto
force-pushed
the
alfonso-uis
branch
from
d8b8864 to
39f0bab
Compare
When rotating or persisting a block, a TableBlockPersisted entry is logged in the WAL and an async snapshot is performed. If on recovery, the entry still exists in the WAL, it means that a snapshot was not performed, since it would have truncated the WAL. This commit ensures the WAL is cleaned up in these cases, since we have seen that this could lead the WAL to grow indefinitely.
asubiotto
force-pushed
the
alfonso-uis
branch
from
39f0bab to
3c10ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.