feat: go-to-definition, fix bugs, update deps, remove unused files #635

aldur · 2025-07-10T09:44:46Z

I am opening this PR as draft since there is a big intersection with #634 and it probably does too many things at once. ~~I have also cherry-picked a couple commits that have since been pushed to develop.~~ I have rebased it on develop so that it should include all changes.

If interesting we can split it into multiple PRs; the intent is to kickstart the conversation here.
I am opening it against develop and leaving review comments inline to explain the rationale behind the changes.

For context, I have been using this project for a while, thank you for creating it!

This PR:

Implements LSP go-to-definition for accounts and commodities.
Fixes bugs related to references and renames, while making them re-use existing code (for instance, using the code to fetch references and then renaming them, instead of duplicating it).
Turns default log-level to INFO (this was making it hard for nvim to cope when editing a big Beancount file).
Adds some more testing and extracts the testing utils to a different file, so they can be re-used across tests / modules.
Updates to the latest tree-sitter version supported by the grammar, which introduced some light breaking changes.
Where possible, uses idiomatic Rust e.g. to create collections from iterators.
Unifies the naming of providers (some started with handle_, others did not).
Updates the README with the latest developments.
Removes a ton of files that, to the best of what I could see, are unused?

I have tested my changes against nvim. I might have obviously missed things, but have tried to add a few tests to increase confidence.

the project version is incorrect

also remove some likely ai generated comments

also remove systemd on darwin. this works on my apple sillicon macbook

chore: fix cargo lock

…pport-relative-path feat: support relative path in journal_root

chore: include LICENSE in the packaged crate

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

aldur · 2025-07-10T09:50:53Z

crates/lsp/src/providers/completion.rs

+    }
+
+    #[test]
+    fn handle_account_completion_case_sensitive() {


I had previously added this test, which is not probably redundant with handle_case_insensitive_completion.

aldur · 2025-07-10T09:51:59Z

crates/lsp/src/providers/references.rs

+    let node =
+        lsp_position_to_node(&doc.content, params.text_document_position.position, tree).unwrap();


Using this instead of the logic that was previously there because otherwise references wouldn't work with the cursor on the first letter of an account (maybe an off-by-one error).

aldur · 2025-07-10T09:52:26Z

crates/lsp/src/utils.rs

        let url = url::Url::from_str(self.as_str()).map_err(|_| ())?;
-        tracing::info!("TOFILEPATH {:#?}", url);
+        tracing::debug!("TOFILEPATH {:#?}", url);


this was needlessly verbose I think

aldur · 2025-07-10T09:52:36Z

flake.nix

@@ -8,132 +8,103 @@
      url = "github:oxalica/rust-overlay";
      inputs.nixpkgs.follows = "nixpkgs";
    };
-    crane = {
-      url = "github:ipetkov/crane";
-      inputs.nixpkgs.follows = "nixpkgs";


input doesn't exist anymore

aldur · 2025-07-10T09:53:06Z

flake.nix

@@ -150,18 +121,10 @@
              git-cliff
              virt-viewer
            ];
-            LD_LIBRARY_PATH = pkgs.lib.makeLibraryPath [


I don't know why this was set, but it was breaking my nvim setup.

aldur · 2025-07-10T09:53:25Z

flake.nix

@@ -8,132 +8,103 @@
      url = "github:oxalica/rust-overlay";
      inputs.nixpkgs.follows = "nixpkgs";
    };
-    crane = {


sorry about all the whitespace noise here!

polarmutex · 2025-07-10T16:47:51Z

I will look at this as soon as I can

polarmutex · 2025-07-11T20:34:12Z

at quick glance it looks good. I am going to merge and test out when i do my financial updates

polarmutex · 2025-07-11T20:38:42Z

can not merge into development , going to cherry pick into development and and lets create issues/discussions on further improvements

polarmutex · 2025-07-11T23:41:44Z

git history is hard to merge. i prefer rebase to merge commits. I will fix the small issues. put the following features in their own pr and have it merge into main

goto account
goto commodity
anything else

aldur · 2025-07-12T08:06:25Z

Sounds good!

eastonman and others added 30 commits March 8, 2025 00:01

chore: fix cargo lock

df73de5

the project version is incorrect

feat: support relative path in journal_root

7103096

also remove some likely ai generated comments

chore: include LICENSE in the packaged crate

4f17614

feat: impl rename and references

eb4b19e

feat: add aarch64-darwin to flake

85c7192

also remove systemd on darwin. this works on my apple sillicon macbook

Merge pull request polarmutex#620 from eastonman/chore-fix-cargo-lock

394862e

chore: fix cargo lock

Merge pull request polarmutex#621 from eastonman/feat-journal-root-su…

f71bdd1

…pport-relative-path feat: support relative path in journal_root

Merge pull request polarmutex#623 from davide125/license

acd51d1

chore: include LICENSE in the packaged crate

chore: bump esbuild from 0.14.46 to 0.25.0 in /vscode (polarmutex#609)

cc89b07

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: bump chrono from 0.4.39 to 0.4.40 (polarmutex#614)

c6bf7d9

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: bump thiserror from 2.0.11 to 2.0.12 (polarmutex#615)

276a83a

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: bump serde_json from 1.0.137 to 1.0.140 (polarmutex#616)

6bd0dde

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: bump anyhow from 1.0.95 to 1.0.97 (polarmutex#617)

e86643c

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: bump bytes from 1.9.0 to 1.10.1 (polarmutex#618)

4f8275d

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: bump serde from 1.0.217 to 1.0.219 (polarmutex#622)

f1e9496

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Update flake

8e4b34a

Update Cargo

a92a9c2

Fix deprecation warning

785e270

Switch default logging to INFO

b981cc2

clippy fixes

71c090c

Remove unused files

9a9d6f7

Update to new version of tree-sitter-beancount

7773c34

Go to account definition

e53dd5f

Go to commodity definition

1eec7f2

Small fixes

32d94d0

Merge branch 'develop'

2750a18

Refactor and fix off-by-one in references

4a7dc82

Add more ts_utils

65dee7a

Update README

d02bc2d

Rely on references to handle renames

3b93e1c

aldur commented Jul 10, 2025

View reviewed changes

aldur added 2 commits July 10, 2025 09:54

Default log level to INFO

7c85b3a

Merge branch 'main' into develop

4c3e72f

polarmutex force-pushed the develop branch 11 times, most recently from e008224 to efaabfd Compare July 12, 2025 04:49

polarmutex force-pushed the develop branch 3 times, most recently from 6ef2b68 to 021e143 Compare July 12, 2025 22:32

polarmutex force-pushed the develop branch from 275e679 to 5122ea5 Compare July 21, 2025 03:20

polarmutex force-pushed the develop branch 2 times, most recently from 97aada2 to f249e00 Compare August 2, 2025 19:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: go-to-definition, fix bugs, update deps, remove unused files #635

feat: go-to-definition, fix bugs, update deps, remove unused files #635

Uh oh!

aldur commented Jul 10, 2025 •

edited

Loading

Uh oh!

aldur Jul 10, 2025

Uh oh!

aldur Jul 10, 2025

Uh oh!

aldur Jul 10, 2025

Uh oh!

aldur Jul 10, 2025

Uh oh!

aldur Jul 10, 2025

Uh oh!

aldur Jul 10, 2025

Uh oh!

polarmutex commented Jul 10, 2025

Uh oh!

polarmutex commented Jul 11, 2025

Uh oh!

polarmutex commented Jul 11, 2025

Uh oh!

polarmutex commented Jul 11, 2025

Uh oh!

aldur commented Jul 12, 2025

Uh oh!

Uh oh!

		let node =
		lsp_position_to_node(&doc.content, params.text_document_position.position, tree).unwrap();

Uh oh!

feat: go-to-definition, fix bugs, update deps, remove unused files #635

Are you sure you want to change the base?

feat: go-to-definition, fix bugs, update deps, remove unused files #635

Uh oh!

Conversation

aldur commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldur Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

aldur Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

aldur Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

aldur Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

aldur Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

aldur Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

polarmutex commented Jul 10, 2025

Uh oh!

polarmutex commented Jul 11, 2025

Uh oh!

polarmutex commented Jul 11, 2025

Uh oh!

polarmutex commented Jul 11, 2025

Uh oh!

aldur commented Jul 12, 2025

Uh oh!

Uh oh!

aldur commented Jul 10, 2025 •

edited

Loading