Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with iPhone 15 devices #839

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mdm84
Copy link

@mdm84 mdm84 commented Mar 14, 2024

No description provided.

@mdm84
Copy link
Author

mdm84 commented Mar 14, 2024

Hi @mbrandonw @stephencelis Can you accept this PR for adding new Devices ?

Copy link

@vincenzpascarella vincenzpascarella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the latest devices can help a lot.


public static func iPhone15Plus(_ orientation: ViewImageConfig.Orientation) -> UITraitCollection {
let base: [UITraitCollection] = [
.init(forceTouchCapability: .available),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure these match the actual values, and other places: https://github.com/playbook-ui/playbook-ios/blob/798f686a6d73318185f85d844876274e91f1f3a2/Sources/Playbook/SnapshotSupport/SnapshotDevice.swift#L739

iPhone X series was the last to support force touch afaik

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @luispadron can you approve it ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have maintainer access unfortunately

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( who can approve for merge ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants