-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow dependencies to be built with pnpm v10 #1448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
electron should not be a 'known' dependency from the extension pov
Until it is resolved in the core Refactor the type of dependency for electron tests-playwright package, we cannot do much in the PR now. |
well you could add
{
"pnpm": {
"neverBuiltDependencies": []
}
} and it'll be like pnpm 9.x |
package.json
Outdated
@@ -7,7 +7,7 @@ | |||
"publisher": "redhat", | |||
"private": true, | |||
"engines": { | |||
"node": ">=20.9.0", | |||
"node": ">=22.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems unrelated
d396726
to
34ecee2
Compare
Signed-off-by: Ondrej Dockal <[email protected]>
34ecee2
to
79e3bc7
Compare
@benoitf sry, missed this comment. @jeffmaury @deboer-tim Now it should be in a shape for review. |
What does this PR do?
Explicitly state the dependencies with build scripts to execute during ie. install lifecycle phase in pnpm v10. This will enable to e2e tests to run.
We have alternatives, I went with the minimal working solution, other options:
When I run
pnpm approve-builds
locally, it updated pnpm-workspace.yaml file instead of package.json.Screenshot / video of UI
What issues does this PR fix or reference?
#1447
How to test this PR?
E2E tests should be passing now.