hack: run the tooling self-tests in validate-source

[vtushar06]

We have a few self-tests sitting next to the scripts they cover, but nothing actually runs them, so they just rot. hack/ci/logformatter.t is broken right now and nobody noticed.

This wires up the three that pass today and only need python3, bash and perl. I ran the target in a clean container to check.

Left out: xref-helpmsgs-manpages.t needs a built podman and docs so it fits validate-binaries better, pr-should-include-tests.t says in its own header that it does not work with the shallow checkout CI uses, and logformatter.t is currently failing.

pr-removes-fixed-skips already runs in validate-source but its test needs Test::Differences, so I added that to the deps.

Does this PR introduce a user-facing change?

None

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[vtushar06]

@Luap99 this came out of reading logformatter for #28828 - its self-test fails on main and on the branch in #29091, and I only spotted it because I ran the .t by hand. Nothing runs any of these, so I wired up the ones that are safe to run.

[packit-as-a-service]

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

[packit-as-a-service]

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

[packit-as-a-service]

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

[lsm5]

/packit build
/packit test

[Luap99]

Historically I think we never bother to test these as part of the CI.
It was more of help for whoever was writing the code, I don't think it is important to have them actually part of the validate though I guess it does not hurt as long as the tests itself are fast enough

[vtushar06]

@lsm5 I went through the failing job and It got killed mid ginkgo run on one of the new cncf-ubuntu-24-96-x86 runners. a rerun would probably just do the same.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Luap99]

I fixed that tests case in my logformatter PR so I think you can add that as well.

[vtushar06]

@Luap99 added it, logformatter.t passes now.

[Luap99]

also no point in adding an extra commit for adding more tests, just keep them all as part of one commit

[ROKUMATE]

@vtushar06 in case it helps with the "one commit" ask ... to squash your two commits into one
You can follow this

git reset --soft HEAD~2               # rewinds the last 2 commits, keeps all changes staged
git commit -s                         # write one combined message
git push --force-with-lease

[vtushar06]

rebased, the two red ones were flakes not this.

[Luap99]

LGTM

@podman-container-tools/podman-maintainers PTAL

[giuseppe]

LGTM