Skip to content

Fix machine init when WSL isn't installed#29063

Merged
Luap99 merged 2 commits into
podman-container-tools:mainfrom
l0rd:fix-machine-init-when-wsl-isnt-installed
Jun 29, 2026
Merged

Fix machine init when WSL isn't installed#29063
Luap99 merged 2 commits into
podman-container-tools:mainfrom
l0rd:fix-machine-init-when-wsl-isnt-installed

Conversation

@l0rd

@l0rd l0rd commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Fixes #29053

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

Fix Hyper-V machine init on hosts where WSL isn't installed

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@l0rd l0rd changed the title Fix machine init when wsl isnt installed Fix machine init when WSL isn't installed Jun 26, 2026
When WSL wasn't installed, the lookup erroneously reported that
a VM with the same name existed. Instead, in this case, the lookup
should return zero matching VMs.

Fixes podman-container-tools#29053

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@l0rd l0rd force-pushed the fix-machine-init-when-wsl-isnt-installed branch from c788140 to 8020330 Compare June 27, 2026 08:52
@github-actions github-actions Bot added the CI label Jun 27, 2026
@l0rd l0rd added the No New Tests Allow PR to proceed without adding regression tests label Jun 27, 2026
@baude

baude commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

LGTM, and thanks @l0rd

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This will need a 6.0 backport
cc @mheon

@Luap99 Luap99 added the 6.0 Breaking changes for Podman 6.0 label Jun 29, 2026
@Luap99 Luap99 merged commit a91d487 into podman-container-tools:main Jun 29, 2026
88 of 90 checks passed
@l0rd

l0rd commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

PR to backport it to v6.0 branch #29075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.0 Breaking changes for Podman 6.0 CI machine No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

podman machine init fails on Hyper-V hosts without WSL installed — cross-provider existence check runs wsl -l --quiet (6.0 regression)

4 participants