Skip to content

Bump bundled krunkit from 1.2.1 to 1.2.2#29030

Draft
slp wants to merge 1 commit into
podman-container-tools:mainfrom
slp:update-krunkit-1.2.2
Draft

Bump bundled krunkit from 1.2.1 to 1.2.2#29030
slp wants to merge 1 commit into
podman-container-tools:mainfrom
slp:update-krunkit-1.2.2

Conversation

@slp

@slp slp commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Bump bundled krunkit to 1.2.2, which comes with libkrun 1.19.2, which includes, among other things, a number of fixes for virtio-fs on macOS.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

Bump bundled krunkit to 1.2.2, which comes with libkrun 1.19.2,
which includes, among other things, a number of fixes for virtio-fs
on macOS.

Signed-off-by: Sergio Lopez <slp@redhat.com>
@mheon

mheon commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

We'll want this in 6.0.1

@mheon

mheon commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

LGTM

@mheon mheon added the No New Tests Allow PR to proceed without adding regression tests label Jun 24, 2026
@TomSweeneyRedHat

Copy link
Copy Markdown
Contributor

LGTM

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this will need to be rebased on upstream main to pass Windows builds.

Anyway, is there some new feature from which Podman would benefit that requires an implementation change? Just in case you know that from top of your head.

@Luap99

Luap99 commented Jun 25, 2026

Copy link
Copy Markdown
Member

I think this should link to/close #21402
At least according to @benoitf this should be the fix for it

@Honny1

Honny1 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Maybe also this: #23018
(I did search with AI)

@benoitf

benoitf commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

so I think it's fixing a lot of issues when user in the container is root but there is still an issue if the user is not root (which works using applehv but not using libkrun)

@slp

slp commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Please put this on hold, I found a breaking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Podman machine rootless connection fails due to storage.conf permissions in FCOS image

6 participants