Skip to content

test: add apiv2 coverage for the manifest-create images query param #28984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefan8 wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −1
Open

test: add apiv2 coverage for the manifest-create images query param #28984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/api/server/register_manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ func (s *APIServer) registerManifestHandlers(r *mux.Router) error {
// - in: query
// name: images
// type: string
// required: true
// description: |
// One or more names of an image or a manifest list. Repeat parameter as needed.
//
Expand Down
34 changes: 34 additions & 0 deletions test/apiv2/15-manifest.at
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,40 @@ RUN >file2
EOF
)

# Create manifest lists and populate them at creation time via the `images`

@Honny1 Honny1 Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: I would add a case like images=containers-storage:$id_abc_image&images=containers-storage:$id_xyz_image with an assertion of '.manifests | length'=2.

# query parameter. This path was previously untested (#22258). `images` may be
# repeated to add more than one image.
t POST "/v4.0.0/libpod/manifests/withimage?images=containers-storage:$id_abc_image" 201 \
.Id~[0-9a-f]\\{64\\}
id_withimage=$(jq -r '.Id' <<<"$output")
t GET /v4.0.0/libpod/manifests/$id_withimage/json 200 \
.manifests[0].digest~sha256:[0-9a-f]\\{64\\} \
'.manifests | length'=1

# The same parameter is honored by the < 4.0.0 create endpoint, where the
# success status is 200 instead of 201.
t POST "/v3.4.0/libpod/manifests/create?name=withimage3&images=containers-storage:$id_xyz_image" 200 \
.Id~[0-9a-f]\\{64\\}
id_withimage3=$(jq -r '.Id' <<<"$output")
t GET /v4.0.0/libpod/manifests/$id_withimage3/json 200 \
.manifests[0].digest~sha256:[0-9a-f]\\{64\\} \
'.manifests | length'=1

# Repeating the `images` parameter adds multiple images to the list in a single
# create call.
t POST "/v4.0.0/libpod/manifests/withimages?images=containers-storage:$id_abc_image&images=containers-storage:$id_xyz_image" 201 \
.Id~[0-9a-f]\\{64\\}
id_withimages=$(jq -r '.Id' <<<"$output")
t GET /v4.0.0/libpod/manifests/$id_withimages/json 200 \
.manifests[0].digest~sha256:[0-9a-f]\\{64\\} \
'.manifests | length'=2

# `images` is optional: the create calls at the top of this file omit it and
# still succeed, even though the API used to document it as required (#22258).
t DELETE /v4.0.0/libpod/manifests/$id_withimage 200
t DELETE /v4.0.0/libpod/manifests/$id_withimages 200
t DELETE /v4.0.0/libpod/manifests/$id_withimage3 200

# manifest add --annotation tests
t POST /v3.4.0/libpod/manifests/$id_abc/add images="[\"containers-storage:$id_abc_image\"]" 200
t PUT /v4.0.0/libpod/manifests/$id_xyz operation='update' images="[\"containers-storage:$id_xyz_image\"]" annotations="{\"foo\":\"bar\"}" annotation="[\"hoge=fuga\"]" 400 \
Expand Down
Loading