docs(run): add --sequential #665
Conversation
|
|
|
@PeterCardenas is attempting to deploy a commit to the pnpm Team on Vercel. A member of the Team first needs to authorize it. |
PeterCardenas
force-pushed
the
add-sequential-docs
branch
from
54eebec to
ac8c9a3
Compare
| manner rather than concurrently. Note that there are no guarantees that the scripts | ||
| will run in topological sort order. |
There was a problem hiding this comment.
I noted this in #672, which is a dupe of this, but it'd be good to clarify here what the expected behaviour is in terms of order of execution when using this with pnpm run "/regex/". My understanding is that in that situation, it'll use the order that the scripts are defined in package.json.
There was a problem hiding this comment.
that's fine but i don't think it should block merging this pr. the reason why there's a dupe im assuming is because we both were trying to find this in the docs but needed to look at the help to find it. the pre work for making something more substantive here would be to have tests in the pnpm repo asserting a particular behavior, because i don't think just looking at the implementation is good enough
There was a problem hiding this comment.
I would probably disagree, I think it'd be better to properly figure out what should be documented first, rather than landing partial documentation that doesn't even acknowledge all the use-cases for it (nothing about this wording implies it can be used w/ pnpm run "/regex/", and in some ways even suggests its not for that due to the reference to topological sorting for pnpm -r).
The --help option for
pnpm rungives a--sequentialoption but it is not shown in the documentation, so we do that in this PR.